[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20230801-portside-prepaid-513f1f39f245-mkl@pengutronix.de>
Date: Tue, 1 Aug 2023 08:37:21 +0200
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Shenwei Wang <shenwei.wang@....com>
Cc: Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>,
Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Shawn Guo <shawnguo@...nel.org>,
Sascha Hauer <s.hauer@...gutronix.de>,
Neil Armstrong <neil.armstrong@...aro.org>,
Kevin Hilman <khilman@...libre.com>,
Vinod Koul <vkoul@...nel.org>, Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Samuel Holland <samuel@...lland.org>,
Jose Abreu <joabreu@...opsys.com>, imx@...ts.linux.dev,
Simon Horman <simon.horman@...igine.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Giuseppe Cavallaro <peppe.cavallaro@...com>,
Nobuhiro Iwamatsu <nobuhiro1.iwamatsu@...hiba.co.jp>,
Fabio Estevam <festevam@...il.com>,
linux-stm32@...md-mailman.stormreply.com,
Jerome Brunet <jbrunet@...libre.com>,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>,
Wong Vee Khee <veekhee@...le.com>,
NXP Linux Team <linux-imx@....com>,
Andrew Halaney <ahalaney@...hat.com>,
Bhupesh Sharma <bhupesh.sharma@...aro.org>,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
Revanth Kumar Uppala <ruppala@...dia.com>,
Jochen Henneberg <jh@...neberg-systemdesign.com>,
linux-amlogic@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Pengutronix Kernel Team <kernel@...gutronix.de>
Subject: Re: [PATCH v3 net 1/2] net: stmmac: add new mode parameter for
fix_mac_speed
On 31.07.2023 11:19:28, Shenwei Wang wrote:
> A mode parameter has been added to the callback function of fix_mac_speed
> to indicate the physical layer type.
>
> The mode can be one the following:
> MLO_AN_PHY - Conventional PHY
> MLO_AN_FIXED - Fixed-link mode
> MLO_AN_INBAND - In-band protocol
>
> Also use short version of 'uint' to replace the 'unsigned int' in the
> function definitions.
There are not many users of 'uint' in the kernel and it's not used in
the stmmac driver so far. From my point of view I would not introduce
it and stick to the standard 'unsigned int'.
Just my 2 cent,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists