linux-kernel - Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd5a43b8-c07d-c906-c0ef-ac8b3ae537e2@suse.com>
Date:   Tue, 1 Aug 2023 10:25:55 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Thomas Gleixner <tglx@...utronix.de>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     x86@...nel.org, Andrew Cooper <andrew.cooper3@...rix.com>,
        Tom Lendacky <thomas.lendacky@....com>,
        Paolo Bonzini <pbonzini@...hat.com>,
        Wei Liu <wei.liu@...nel.org>,
        Arjan van de Ven <arjan@...ux.intel.com>,
        Michael Kelley <mikelley@...rosoft.com>,
        Peter Keresztes Schmidt <peter@...esztesschmidt.de>,
        "Peter Zijlstra (Intel)" <peterz@...radead.org>
Subject: Re: [patch V2 50/58] x86/apic: Provide common init infrastructure

On 01.08.23 10:23, Thomas Gleixner wrote:
> On Tue, Aug 01 2023 at 09:37, Juergen Gross wrote:
>> On 01.08.23 09:32, Thomas Gleixner wrote:
>>> On Tue, Aug 01 2023 at 09:08, Juergen Gross wrote:
>>>> On 01.08.23 08:49, Juergen Gross wrote:
>>>>     void __init xen_init_apic(void)
>>>>     {
>>>>            x86_apic_ops.io_apic_read = xen_io_apic_read;
>>>> -       /* On PV guests the APIC CPUID bit is disabled so none of the
>>>> -        * routines end up executing. */
>>>> -       if (!xen_initial_domain())
>>>> -               apic_install_driver(&xen_pv_apic);
>>>> -
>>>>            x86_platform.apic_post_init = xen_apic_check;
>>>
>>> I don't think this one is needed.
>>
>> Indeed.
> 
> Can you send a real patch please which I can add to that pile at the
> right place?

I think adding it right after patch 50 should be fine?

The WARN() will be issued only with patch 58.


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (496 bytes)