linux-kernel - RE: [PATCH] drm/amdgpu: Clean up errors in vega20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DM6PR12MB26192EB1ADCC6973C37B6E2AE40AA@DM6PR12MB2619.namprd12.prod.outlook.com>
Date:   Tue, 1 Aug 2023 09:25:29 +0000
From:   "Quan, Evan" <Evan.Quan@....com>
To:     Ran Sun <sunran001@...suo.com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "airlied@...il.com" <airlied@...il.com>,
        "daniel@...ll.ch" <daniel@...ll.ch>
CC:     "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c

[AMD Official Use Only - General]

Reviewed-by: Evan Quan <evan.quan@....com>

> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@...ts.freedesktop.org> On Behalf Of Ran
> Sun
> Sent: Tuesday, August 1, 2023 4:03 PM
> To: Deucher, Alexander <Alexander.Deucher@....com>; airlied@...il.com;
> daniel@...ll.ch
> Cc: Ran Sun <sunran001@...suo.com>; dri-devel@...ts.freedesktop.org;
> amd-gfx@...ts.freedesktop.org; linux-kernel@...r.kernel.org
> Subject: [PATCH] drm/amdgpu: Clean up errors in vega20_baco.c
>
> Fix the following errors reported by checkpatch:
>
> ERROR: that open brace { should be on the previous line
> ERROR: space required before the open parenthesis '('
>
> Signed-off-by: Ran Sun <sunran001@...suo.com>
> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> index 8d99c7a5abf8..994c0d374bfa 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega20_baco.c
> @@ -31,8 +31,7 @@
>
>  #include "amdgpu_ras.h"
>
> -static const struct soc15_baco_cmd_entry clean_baco_tbl[] = -{
> +static const struct soc15_baco_cmd_entry clean_baco_tbl[] = {
>       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_6), 0,
> 0, 0, 0},
>       {CMD_WRITE, SOC15_REG_ENTRY(NBIF, 0, mmBIOS_SCRATCH_7), 0,
> 0, 0, 0},  }; @@ -90,11 +89,11 @@ int vega20_baco_set_state(struct
> pp_hwmgr *hwmgr, enum BACO_STATE state)
>                       data |= 0x80000000;
>                       WREG32_SOC15(THM, 0, mmTHM_BACO_CNTL,
> data);
>
> -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> +                     if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
>                                       PPSMC_MSG_EnterBaco, 0, NULL))
>                               return -EINVAL;
>               } else {
> -                     if(smum_send_msg_to_smc_with_parameter(hwmgr,
> +                     if
> (smum_send_msg_to_smc_with_parameter(hwmgr,
>                                       PPSMC_MSG_EnterBaco, 1, NULL))
>                               return -EINVAL;
>               }
> --
> 2.17.1