linux-kernel - Re: [PATCH v2] tty: vt: Remove some repetitive initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 1 Aug 2023 15:23:46 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     oushixiong <oushixiong@...inos.cn>
Cc:     Jiri Slaby <jirislaby@...nel.org>,
        Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        linux-kernel@...r.kernel.org, linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] tty: vt: Remove some repetitive initialization

On Tue, Aug 01, 2023 at 07:57:24PM +0800, oushixiong wrote:
> 
> Members vc_col???vc_rows and vc_size_row of the struct vc_data have been

Odd ??? characters?

> initialized in visual_init(), so it no longer to initialized them again
> in vc_init().
> 
> v1->v2:
> 	- Fix the comment.

This needs to be below the --- line, right?

> 
> Signed-off-by: oushixiong <oushixiong@...inos.cn>
> ---
>  drivers/tty/vt/vt.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)

thanks.

greg k-h