linux-kernel - Re: [PATCH] lib/Kconfig.debug: fix grammar in RUST_BUILD_ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANiq72kxOEt2Kb_rxY0+WD6uu=NXy+6PGMvGjTHfNFVXucgH7w@mail.gmail.com>
Date:   Wed, 2 Aug 2023 17:29:23 +0200
From:   Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To:     Timo Grautstück <timo.gr@...mail.de>
Cc:     rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH] lib/Kconfig.debug: fix grammar in RUST_BUILD_ASSERT_ALLOW

On Sun, Jun 25, 2023 at 12:05 PM Timo Grautstück <timo.gr@...mail.de> wrote:
>
> Ahh ok, i also dont think you can call it a "bug". Is it not possible to
> simply remove the `Closes:` tag from the patch and not categorize the
> whole thing as a "bug"?

I think either way is fine. Since we have an issue in the tracker and
it is a fix, even if trivial, let's go with something like:

    Reported-by: Miguel Ojeda <ojeda@...nel.org>
    Closes: https://github.com/Rust-for-Linux/linux/issues/1006
    Fixes: <hash> ("<description>")
    Signed-off-by: <fixed real name> <timo.gr@...mail.de>

For the formatting of the `Fixes:` tag, I recommend using the git
`--pretty=` config shown in
https://docs.kernel.org/process/submitting-patches.html.

Cheers,
Miguel