linux-kernel - Re: [PATCH] lib/Kconfig.debug: fix grammar in RUST_BUILD_ASSERT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PAXP190MB16316300F2E89EC06A4E3AF78B21A@PAXP190MB1631.EURP190.PROD.OUTLOOK.COM>
Date:   Sun, 25 Jun 2023 12:05:32 +0200
From:   Timo Grautstück <timo.gr@...mail.de>
To:     Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
Cc:     rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
        Miguel Ojeda <ojeda@...nel.org>
Subject: Re: [PATCH] lib/Kconfig.debug: fix grammar in RUST_BUILD_ASSERT_ALLOW

Miguel Ojeda <miguel.ojeda.sandonis@...il.com> writes:

> On Mon, Jun 5, 2023 at 6:12 PM <timo.gr@...mail.de> wrote:
>>
>> From: Timgrau <timo.gr@...mail.de>
>>
>> Just a grammar fix in lib/Kconfig.debug, under the config option RUST_BUILD_ASSERT_ALLOW.
>>
>> Signed-off-by: Timgrau <timo.gr@...mail.de>
>> Suggested-by: Miguel Ojeda <ojeda@...nel.org>
>> Link: https://github.com/Rust-for-Linux/linux/issues/1006#issue-1696318406
>> Closes: https://github.com/Rust-for-Linux/linux/issues/1006#issue-1696318406
>
> Thanks for the patch!
>
> A few notes:
>
>   - From a quick look, I think "Timgrau" is not a known identity to
> the kernel, right? (e.g. I couldn't find any other commit on that
> name). Assuming I am not mistaken, could you please instead your real
> name?

Right, I already thought so. My bad, will change it.
>
>   - When I wrote the report, I wrongly suggested `Suggested-by` +
> `Link` because I didn't consider this a "bug". But you are probably
> right that should be considered a fix anyway, so instead we should use
> `Reported-by` and `Closes`. So could you please remove the `Link` and
> change the `Suggested` to `Reported`?

Ahh ok, i also dont think you can call it a "bug". Is it not possible to
simply remove the `Closes:` tag from the patch and not categorize the
whole thing as a "bug"?
>
>   - Also, since this is now a fix, could you please also add the `Fixes:` tag?
>
>   - For the `Closes`, you can remove the URL fragment part, i.e.
> `#issue-1696318406`, since it is anyway the first comment.

In that case, these two points/notes above are not needet right?
>
> If you could change those bits and send a v2, that would be great. Thanks!
>
> Cheers,
> Miguel