linux-kernel - Re: [PATCH bpf-next v4 0/3] bpf, arm64: use BPF prog pack allocator in BPF JIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 2 Aug 2023 14:02:39 -0700
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Puranjay Mohan <puranjay12@...il.com>,
        Florent Revest <revest@...omium.org>
Cc:     Mark Rutland <mark.rutland@....com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Alexei Starovoitov <ast@...nel.org>,
        Andrii Nakryiko <andrii@...nel.org>,
        Martin KaFai Lau <martin.lau@...ux.dev>,
        Song Liu <song@...nel.org>,
        Catalin Marinas <catalin.marinas@....com>,
        bpf <bpf@...r.kernel.org>, KP Singh <kpsingh@...nel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH bpf-next v4 0/3] bpf, arm64: use BPF prog pack allocator
 in BPF JIT

On Sun, Jul 30, 2023 at 10:22 AM Puranjay Mohan <puranjay12@...il.com> wrote:
>
> Hi Mark,
> I am really looking forward to your feedback on this series.
>
> On Mon, Jul 17, 2023 at 9:50 AM Puranjay Mohan <puranjay12@...il.com> wrote:
> >
> > Hi Mark,
> >
> > On Mon, Jul 3, 2023 at 7:15 PM Mark Rutland <mark.rutland@....com> wrote:
> > >
> > > On Mon, Jul 03, 2023 at 06:40:21PM +0200, Daniel Borkmann wrote:
> > > > Hi Mark,
> > >
> > > Hi Daniel,
> > >
> > > > On 6/26/23 10:58 AM, Puranjay Mohan wrote:
> > > > > BPF programs currently consume a page each on ARM64. For systems with many BPF
> > > > > programs, this adds significant pressure to instruction TLB. High iTLB pressure
> > > > > usually causes slow down for the whole system.
> > > > >
> > > > > Song Liu introduced the BPF prog pack allocator[1] to mitigate the above issue.
> > > > > It packs multiple BPF programs into a single huge page. It is currently only
> > > > > enabled for the x86_64 BPF JIT.
> > > > >
> > > > > This patch series enables the BPF prog pack allocator for the ARM64 BPF JIT.
> > >
> > > > If you get a chance to take another look at the v4 changes from Puranjay and
> > > > in case they look good to you reply with an Ack, that would be great.
> > >
> > > Sure -- this is on my queue of things to look at; it might just take me a few
> > > days to get the time to give this a proper look.
> > >
> > > Thanks,
> > > Mark.
> >
> > I am eagerly looking forward to your feedback on this series.

Mark, Catalin, Florent, KP,

This patch set was submitted on June 26 !
It's not acceptable to delay review for so long.
Please review asap.