linux-kernel - Re: [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform device for TRBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2c1894c4-c0e3-ea90-d5f6-24c3ed8c0e4f@arm.com>
Date:   Wed, 2 Aug 2023 11:11:11 +0100
From:   Suzuki K Poulose <suzuki.poulose@....com>
To:     Anshuman Khandual <anshuman.khandual@....com>,
        Will Deacon <will@...nel.org>
Cc:     linux-arm-kernel@...ts.infradead.org,
        Catalin Marinas <catalin.marinas@....com>,
        Mark Rutland <mark.rutland@....com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2 2/4] arm_pmu: acpi: Add a representative platform
 device for TRBE

On 02/08/2023 02:07, Anshuman Khandual wrote:
> 
> 
> On 8/1/23 20:21, Will Deacon wrote:
>> On Tue, Aug 01, 2023 at 03:10:50PM +0530, Anshuman Khandual wrote:
>>> diff --git a/include/linux/perf/arm_pmu.h b/include/linux/perf/arm_pmu.h
>>> index a0801f68762b..7ec26d21303d 100644
>>> --- a/include/linux/perf/arm_pmu.h
>>> +++ b/include/linux/perf/arm_pmu.h
>>> @@ -187,5 +187,6 @@ void armpmu_free_irq(int irq, int cpu);
>>>   #endif /* CONFIG_ARM_PMU */
>>>   
>>>   #define ARMV8_SPE_PDEV_NAME "arm,spe-v1"
>>> +#define ARMV8_TRBE_PDEV_NAME "arm-trbe-acpi"
>>
>> Why is the TRBE name formatted differently to the SPE one?
> 
> Nothing specific, although "arm,spe-v1" seemed more like a DT naming
> scheme. But could change the name as "arm,trbe-v1" to be in sync with
> SPE here.

Do we really need v1 ? I would leave it as arm,trbe

Suzuki