[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ce99a777-10cc-f380-65c8-ef76843ca181@linaro.org>
Date: Wed, 2 Aug 2023 15:38:42 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Marek Vasut <marex@...x.de>,
Neil Armstrong <neil.armstrong@...aro.org>,
Andrzej Hajda <andrzej.hajda@...el.com>,
Robert Foss <rfoss@...nel.org>,
Laurent Pinchart <Laurent.pinchart@...asonboard.com>,
Jonas Karlman <jonas@...boo.se>,
Jernej Skrabec <jernej.skrabec@...il.com>,
David Airlie <airlied@...il.com>,
Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
Jagan Teki <jagan@...rulasolutions.com>,
Abhinav Kumar <quic_abhinavk@...cinc.com>,
Amit Pundir <amit.pundir@...aro.org>
Subject: Re: [PATCH] Revert "drm/bridge: lt9611: Do not generate HFP/HBP/HSA
and EOT packet"
On 02/08/2023 15:07, Marek Vasut wrote:
> On 8/2/23 10:52, Neil Armstrong wrote:
>> This reverts commit [1] to fix display regression on the Dragonboard 845c
>> (SDM845) devboard.
>>
>> There's a mismatch on the real action of the following flags:
>> - MIPI_DSI_MODE_VIDEO_NO_HSA
>> - MIPI_DSI_MODE_VIDEO_NO_HFP
>> - MIPI_DSI_MODE_VIDEO_NO_HBP
>> which leads to a non-working display on qcom platforms.
>>
>> [1] 8ddce13ae696 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA and
>> EOT packet")
>>
>> Cc: Marek Vasut <marex@...x.de>
>> Cc: Robert Foss <rfoss@...nel.org>
>> Cc: Jagan Teki <jagan@...rulasolutions.com>
>> Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
>> Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>
>> Fixes: 8ddce13ae69 ("drm/bridge: lt9611: Do not generate HFP/HBP/HSA
>> and EOT packet")
>> Reported-by: Amit Pundir <amit.pundir@...aro.org>
>> Link:
>> https://lore.kernel.org/r/CAMi1Hd0TD=2z_=bcDrht3H_wiLvAFcv8Z-U_r_KUOoeMc6UMjw@mail.gmail.com/
>> Signed-off-by: Neil Armstrong <neil.armstrong@...aro.org>
>
> This breaks LT9611 operation on i.MX8M Mini/Nano/Plus, so, NAK.
>
> I am currently using this LT9611 with Linux 6.1.y in production and this
> is not acceptable. I also believe the correct fix is on the MSM side,
> not on the LT9611 driver side, since MSM incorrectly implements these
> flags.
Up to now we saw no proof that MSM incorrectly implements the flags.
--
With best wishes
Dmitry
Powered by blists - more mailing lists