linux-kernel - Re: [PATCH v8 03/14] dmaengine: idxd: Export drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52b44427-4670-15c1-ef96-8344413e76cc@intel.com>
Date:   Thu, 3 Aug 2023 08:24:15 -0700
From:   Dave Jiang <dave.jiang@...el.com>
To:     Vinod Koul <vkoul@...nel.org>,
        Tom Zanussi <tom.zanussi@...ux.intel.com>
CC:     <herbert@...dor.apana.org.au>, <davem@...emloft.net>,
        <fenghua.yu@...el.com>, <tony.luck@...el.com>,
        <wajdi.k.feghali@...el.com>, <james.guilford@...el.com>,
        <kanchana.p.sridhar@...el.com>, <vinodh.gopal@...el.com>,
        <giovanni.cabiddu@...el.com>, <linux-kernel@...r.kernel.org>,
        <linux-crypto@...r.kernel.org>, <dmaengine@...r.kernel.org>
Subject: Re: [PATCH v8 03/14] dmaengine: idxd: Export drv_enable/disable and
 related functions



On 8/3/23 06:15, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
>> To allow idxd sub-drivers to enable and disable wqs, export them.
>>
>> Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
>> Reviewed-by: Dave Jiang <dave.jiang@...el.com>
>> Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
>> ---
>>   drivers/dma/idxd/device.c | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
>> index 5abbcc61c528..87ad95fa3f98 100644
>> --- a/drivers/dma/idxd/device.c
>> +++ b/drivers/dma/idxd/device.c
>> @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
>>   err:
>>   	return rc;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
> 
> Sorry this is a very generic symbol, pls dont export it. I would make it
> idxd_drv_enable_wq()

That's true. Although just a note it's only exported in the IDXD 
namespace. So maybe ok?

> 
>>   
>>   void drv_disable_wq(struct idxd_wq *wq)
>>   {
>> @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
>>   	wq->type = IDXD_WQT_NONE;
>>   	wq->client_count = 0;
>>   }
>> +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
>>   
>>   int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
>>   {
>> -- 
>> 2.34.1
>