linux-kernel - Re: [PATCH v8 03/14] dmaengine: idxd: Export drv

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89596072f7fee8a877e08e01cf937136c4a39003.camel@linux.intel.com>
Date:   Thu, 03 Aug 2023 09:24:07 -0500
From:   Tom Zanussi <tom.zanussi@...ux.intel.com>
To:     Vinod Koul <vkoul@...nel.org>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        fenghua.yu@...el.com, dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, vinodh.gopal@...el.com,
        giovanni.cabiddu@...el.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v8 03/14] dmaengine: idxd: Export drv_enable/disable and
 related functions

Hi Vinod,

On Thu, 2023-08-03 at 18:45 +0530, Vinod Koul wrote:
> On 31-07-23, 16:29, Tom Zanussi wrote:
> > To allow idxd sub-drivers to enable and disable wqs, export them.
> > 
> > Signed-off-by: Tom Zanussi <tom.zanussi@...ux.intel.com>
> > Reviewed-by: Dave Jiang <dave.jiang@...el.com>
> > Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
> > ---
> >  drivers/dma/idxd/device.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/drivers/dma/idxd/device.c b/drivers/dma/idxd/device.c
> > index 5abbcc61c528..87ad95fa3f98 100644
> > --- a/drivers/dma/idxd/device.c
> > +++ b/drivers/dma/idxd/device.c
> > @@ -1505,6 +1505,7 @@ int drv_enable_wq(struct idxd_wq *wq)
> >  err:
> >         return rc;
> >  }
> > +EXPORT_SYMBOL_NS_GPL(drv_enable_wq, IDXD);
> 
> Sorry this is a very generic symbol, pls dont export it. I would make
> it
> idxd_drv_enable_wq()

Yeah, good point, I'll do that for the next version.  And thanks for
all your Acks!

Tom

> 
> >  
> >  void drv_disable_wq(struct idxd_wq *wq)
> >  {
> > @@ -1526,6 +1527,7 @@ void drv_disable_wq(struct idxd_wq *wq)
> >         wq->type = IDXD_WQT_NONE;
> >         wq->client_count = 0;
> >  }
> > +EXPORT_SYMBOL_NS_GPL(drv_disable_wq, IDXD);
> >  
> >  int idxd_device_drv_probe(struct idxd_dev *idxd_dev)
> >  {
> > -- 
> > 2.34.1
>