linux-kernel - Re: [PATCH v8 07/14] dmaengine: idxd: add callback support for iaa crypto

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZMupdvn8J+mM2Kak@matsya>
Date:   Thu, 3 Aug 2023 18:49:50 +0530
From:   Vinod Koul <vkoul@...nel.org>
To:     Tom Zanussi <tom.zanussi@...ux.intel.com>
Cc:     herbert@...dor.apana.org.au, davem@...emloft.net,
        fenghua.yu@...el.com, dave.jiang@...el.com, tony.luck@...el.com,
        wajdi.k.feghali@...el.com, james.guilford@...el.com,
        kanchana.p.sridhar@...el.com, vinodh.gopal@...el.com,
        giovanni.cabiddu@...el.com, linux-kernel@...r.kernel.org,
        linux-crypto@...r.kernel.org, dmaengine@...r.kernel.org
Subject: Re: [PATCH v8 07/14] dmaengine: idxd: add callback support for iaa
 crypto

On 31-07-23, 16:29, Tom Zanussi wrote:
> Create a lightweight callback interface to allow idxd sub-drivers to
> be notified when work sent to idxd wqs has completed.
> 
> For a sub-driver to be notified of work completion, it needs to:
> 
>   - Set the descriptor's 'Request Completion Interrupt'
>     (IDXD_OP_FLAG_RCI)
> 
>   - Set the sub-driver desc_complete() callback when registering the
>     sub-driver e.g.:
> 
>       struct idxd_device_driver my_drv = {
>             .probe = my_probe,
>             .desc_complete = my_complete,
>       }
> 
>   - Set the sub-driver-specific context in the sub-driver's descriptor
>     e.g:
> 
>       idxd_desc->crypto.req = req;
>       idxd_desc->crypto.tfm = tfm;
>       idxd_desc->crypto.src_addr = src_addr;
>       idxd_desc->crypto.dst_addr = dst_addr;
> 
> When the work completes and the completion irq fires, idxd will invoke
> the desc_complete() callback with pointers to the descriptor, context,
> and completion_type.

Acked-by: Vinod Koul <vkoul@...nel.org>

-- 
~Vinod