linux-kernel - Re: [PATCH -next] workqueue: use LIST_HEAD to initialize cull

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJhGHyDMoX6MfPiEBgJ_6CCCetCfFsas=TEQU8PfNuUjE9TH0w@mail.gmail.com>
Date:   Thu, 3 Aug 2023 17:50:42 +0800
From:   Lai Jiangshan <jiangshanlai@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     linux-kernel@...r.kernel.org, tj@...nel.org
Subject: Re: [PATCH -next] workqueue: use LIST_HEAD to initialize cull_list

On Thu, Aug 3, 2023 at 3:54 PM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> Use LIST_HEAD() to initialize cull_list instead of open-coding it.
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>

Reviewed-by: Lai Jiangshan <jiangshanlai@...il.com>

> ---
>  kernel/workqueue.c | 7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/kernel/workqueue.c b/kernel/workqueue.c
> index 3ddd0d599dab..ae975a7c9f69 100644
> --- a/kernel/workqueue.c
> +++ b/kernel/workqueue.c
> @@ -2307,9 +2307,8 @@ static void idle_worker_timeout(struct timer_list *t)
>  static void idle_cull_fn(struct work_struct *work)
>  {
>         struct worker_pool *pool = container_of(work, struct worker_pool, idle_cull_work);
> -       struct list_head cull_list;
> +       LIST_HEAD(cull_list);
>
> -       INIT_LIST_HEAD(&cull_list);
>         /*
>          * Grabbing wq_pool_attach_mutex here ensures an already-running worker
>          * cannot proceed beyong worker_detach_from_pool() in its self-destruct
> @@ -3875,10 +3874,8 @@ static void rcu_free_pool(struct rcu_head *rcu)
>  static void put_unbound_pool(struct worker_pool *pool)
>  {
>         DECLARE_COMPLETION_ONSTACK(detach_completion);
> -       struct list_head cull_list;
>         struct worker *worker;
> -
> -       INIT_LIST_HEAD(&cull_list);
> +       LIST_HEAD(cull_list);
>
>         lockdep_assert_held(&wq_pool_mutex);
>
> --
> 2.25.1
>