lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Fri,  4 Aug 2023 09:35:17 +0800
From:   kah.jing.lee@...el.com
To:     dinguyen@...nel.org
Cc:     linux-kernel@...r.kernel.org, tien.sung.ang@...el.com,
        Kah Jing Lee <kah.jing.lee@...el.com>
Subject: [PATCH] drivers: firmware: stratix10-rsu: Fix max_retry counter value

From: Kah Jing Lee <kah.jing.lee@...el.com>

Fix the max_retry value because the value is truncated at scnprintf format
specifier, with added hex symbol and newline.

Signed-off-by: Kah Jing Lee <kah.jing.lee@...el.com>
---
 drivers/firmware/stratix10-rsu.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c
index e51c95f8d445..98ec39f6dae8 100644
--- a/drivers/firmware/stratix10-rsu.c
+++ b/drivers/firmware/stratix10-rsu.c
@@ -405,8 +405,7 @@ static ssize_t max_retry_show(struct device *dev,
 	if (!priv)
 		return -ENODEV;
 
-	return scnprintf(buf, sizeof(priv->max_retry),
-			 "0x%08x\n", priv->max_retry);
+	return scnprintf(buf, PAGE_SIZE, "0x%08x\n", priv->max_retry);
 }
 
 static ssize_t dcmf0_show(struct device *dev,

base-commit: c1a515d3c0270628df8ae5f5118ba859b85464a2
-- 
2.25.1

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ