linux-kernel - Re: [PATCH] drivers: firmware: stratix10-rsu: Fix max

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <711f42de-34d8-c27a-e058-5fa460012a69@kernel.org>
Date:   Sun, 6 Aug 2023 12:51:53 -0500
From:   Dinh Nguyen <dinguyen@...nel.org>
To:     kah.jing.lee@...el.com
Cc:     linux-kernel@...r.kernel.org, tien.sung.ang@...el.com
Subject: Re: [PATCH] drivers: firmware: stratix10-rsu: Fix max_retry counter
 value



On 8/3/23 20:35, kah.jing.lee@...el.com wrote:
> From: Kah Jing Lee <kah.jing.lee@...el.com>
> 
> Fix the max_retry value because the value is truncated at scnprintf format
> specifier, with added hex symbol and newline.
> 
> Signed-off-by: Kah Jing Lee <kah.jing.lee@...el.com>
> ---
>   drivers/firmware/stratix10-rsu.c | 3 +--
>   1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/firmware/stratix10-rsu.c b/drivers/firmware/stratix10-rsu.c
> index e51c95f8d445..98ec39f6dae8 100644
> --- a/drivers/firmware/stratix10-rsu.c
> +++ b/drivers/firmware/stratix10-rsu.c
> @@ -405,8 +405,7 @@ static ssize_t max_retry_show(struct device *dev,
>   	if (!priv)
>   		return -ENODEV;
>   
> -	return scnprintf(buf, sizeof(priv->max_retry),
> -			 "0x%08x\n", priv->max_retry);
> +	return scnprintf(buf, PAGE_SIZE, "0x%08x\n", priv->max_retry);
>   }
>   

This would be a good time to switch over to use sysfs_emit()

Dinh