[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNEBqDamvHMMRqRw@smile.fi.intel.com>
Date: Mon, 7 Aug 2023 17:37:28 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
Mario Limonciello <mario.limonciello@....com>,
Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org,
Mika Westerberg <mika.westerberg@...ux.intel.com>,
Jan Dabros <jsd@...ihalf.com>
Subject: Re: [PATCH v1 9/9] i2c: designware: Fix spelling and other issues in
the comments
On Fri, Aug 04, 2023 at 11:41:57PM +0200, Andi Shyti wrote:
...
> > @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
> > {
> > mutex_lock(&psp_i2c_access_mutex);
> >
> > - /* Return early if mailbox was malfunctional */
> > + /* Return early if mailbox was malfunctioned */
>
> I think "was malfunctioned" is not really correct... maybe "has
> malfunctioned"? "is malfunctioning"?
I first stumbled over this, but than I read the function name...
I guess they are correct. So I think I need to drop this hunk.
...
> > - * transfer supported by the driver (for 400KHz this is
> > + * transfer supported by the driver (for 400kHz this is
>
> what did you change here? :)
Proper units. k is the official SI prefix for KILO.
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists