linux-kernel - Re: [PATCH v1 9/9] i2c: designware: Fix spelling and other issues in the comments

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230807150413.3nv75vlhm3z3aule@intel.intel>
Date:   Mon, 7 Aug 2023 17:04:13 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     Jarkko Nikula <jarkko.nikula@...ux.intel.com>,
        Mario Limonciello <mario.limonciello@....com>,
        Wolfram Sang <wsa@...nel.org>, linux-i2c@...r.kernel.org,
        linux-kernel@...r.kernel.org,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        Jan Dabros <jsd@...ihalf.com>
Subject: Re: [PATCH v1 9/9] i2c: designware: Fix spelling and other issues in
 the comments

On Mon, Aug 07, 2023 at 05:37:28PM +0300, Andy Shevchenko wrote:
> On Fri, Aug 04, 2023 at 11:41:57PM +0200, Andi Shyti wrote:
> 
> ...
> 
> > > @@ -210,12 +210,12 @@ static void psp_release_i2c_bus(void)
> > >  {
> > >  	mutex_lock(&psp_i2c_access_mutex);
> > >  
> > > -	/* Return early if mailbox was malfunctional */
> > > +	/* Return early if mailbox was malfunctioned */
> > 
> > I think "was malfunctioned" is not really correct... maybe "has
> > malfunctioned"? "is malfunctioning"?
> 
> I first stumbled over this, but than I read the function name...
> I guess they are correct. So I think I need to drop this hunk.

"malfunctional" actually doesn't exist as a word. I think this is
correct:

  "Return early if the mailbox is malfunctioning"

> ...
> 
> > > -		 * transfer supported by the driver (for 400KHz this is
> > > +		 * transfer supported by the driver (for 400kHz this is
> > 
> > what did you change here? :)
> 
> Proper units. k is the official SI prefix for KILO.

oh right! didn't see it :)

Thanks,
Andi