linux-kernel - Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230807-euphemism-trailing-ef4130dc7437@spud>
Date:   Mon, 7 Aug 2023 15:39:22 +0100
From:   Conor Dooley <conor@...nel.org>
To:     MD Danish Anwar <danishanwar@...com>
Cc:     Suman Anna <s-anna@...com>, Conor Dooley <conor+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-remoteproc@...r.kernel.org, linux-omap@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org, vigneshr@...com, srk@...com,
        nm@...com
Subject: Re: [PATCH] dt-bindings: remoteproc: pru: Add Interrupt property

On Mon, Aug 07, 2023 at 04:38:36PM +0530, MD Danish Anwar wrote:
> Add interrupts and interrupt-names protperties for PRU and RTU cores.
> 
> Signed-off-by: MD Danish Anwar <danishanwar@...com>
> ---
>  .../bindings/remoteproc/ti,pru-rproc.yaml     | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> index cd55d80137f7..6970316943bb 100644
> --- a/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> +++ b/Documentation/devicetree/bindings/remoteproc/ti,pru-rproc.yaml
> @@ -66,6 +66,16 @@ properties:
>        Should contain the name of the default firmware image
>        file located on the firmware search path.
>  
> +  interrupts:
> +    maxItems: 1
> +    description:
> +      Interrupt specifiers enable the virtio/rpmsg communication between MPU
> +      and the PRU/RTU cores.
> +
> +  interrupt-names:
> +    items:
> +      - const: vring
> +
>  if:
>    properties:
>      compatible:
> @@ -171,6 +181,9 @@ examples:
>                <0x22400 0x100>;
>          reg-names = "iram", "control", "debug";
>          firmware-name = "am65x-pru0_0-fw";
> +        interrupt-parent = <&icssg0_intc>;
> +        interrupts = <16 2 2>;
> +        interrupt-names = "vring";
>        };

These examples would probably be more helpful if they used the
appropriate defines, no?

>  
>        rtu0_0: rtu@...0 {
> @@ -180,6 +193,9 @@ examples:
>                <0x23400 0x100>;
>          reg-names = "iram", "control", "debug";
>          firmware-name = "am65x-rtu0_0-fw";
> +        interrupt-parent = <&icssg0_intc>;
> +        interrupts = <20 4 4>;
> +        interrupt-names = "vring";
>        };
>  
>        tx_pru0_0: txpru@...0 {
> @@ -198,6 +214,9 @@ examples:
>                <0x24400 0x100>;
>          reg-names = "iram", "control", "debug";
>          firmware-name = "am65x-pru0_1-fw";
> +        interrupt-parent = <&icssg0_intc>;
> +        interrupts = <18 3 3>;
> +        interrupt-names = "vring";
>        };
>  
>        rtu0_1: rtu@...0 {
> @@ -207,6 +226,9 @@ examples:
>                <0x23c00 0x100>;
>          reg-names = "iram", "control", "debug";
>          firmware-name = "am65x-rtu0_1-fw";
> +        interrupt-parent = <&icssg0_intc>;
> +        interrupts = <22 5 5>;
> +        interrupt-names = "vring";
>        };
>  
>        tx_pru0_1: txpru@...0 {
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)