linux-kernel - Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 7 Aug 2023 23:34:52 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Anton Eliasson <anton.eliasson@...s.com>
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Alim Akhtar <alim.akhtar@...sung.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-serial@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel@...s.com
Subject: Re: [PATCH] tty: serial: samsung: Set missing PM ops for hibernation
 support

Hi Anton,

On Mon, Aug 07, 2023 at 11:57:04AM +0200, Anton Eliasson wrote:
> On 05/08/2023 23.38, Andi Shyti wrote:
> > Hi Anton,
> > 
> > On Thu, Aug 03, 2023 at 01:26:42PM +0200, Anton Eliasson wrote:
> > > At least freeze, restore and thaw need to be set in order for the driver
> > > to support system hibernation. The existing suspend/resume functions can
> > > be reused since those functions don't touch the device's power state or
> > > wakeup capability. Use the helper macros SET_SYSTEM_SLEEP_PM_OPS and
> > > SET_NOIRQ_SYSTEM_SLEEP_PM_OPS for symmetry with similar drivers.
> > and why do we need hibernation in this device?
> > 
> > Andi
> 
> Hi!
> 
> I wanted to test whether hibernation is possible on our SoC, even though it
> is not a common feature on embedded ARM systems. This is the only mainline
> driver that I found that needed modification, for my proof-of-concept
> anyway, and I couldn't see any harm in the change.

Thanks, makes sense, mine was just curiosity, can I know which
SoC you are testing that is using the samsung serial device?

You can add my r-b, anyway:

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

Thanks,
Andi