linux-kernel - Re: [PATCH v3 4.14 1/1] test_firmware: fix the memory leaks with the reqs buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2023080705-poet-nickname-5e08@gregkh>
Date:   Mon, 7 Aug 2023 11:15:17 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
Cc:     linux-kernel@...r.kernel.org, Luis Chamberlain <mcgrof@...nel.org>,
        Russ Weight <russell.h.weight@...el.com>,
        Tianfei Zhang <tianfei.zhang@...el.com>,
        Shuah Khan <shuah@...nel.org>,
        Colin Ian King <colin.i.king@...il.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kselftest@...r.kernel.org, stable@...r.kernel.org,
        Dan Carpenter <error27@...il.com>, Takashi Iwai <tiwai@...e.de>
Subject: Re: [PATCH v3 4.14 1/1] test_firmware: fix the memory leaks with the
 reqs buffer

On Fri, Aug 04, 2023 at 07:00:18PM +0200, Mirsad Todorovac wrote:
> [ commit be37bed754ed90b2655382f93f9724b3c1aae847 upstream ]
> 
> Dan Carpenter spotted that test_fw_config->reqs will be leaked if
> trigger_batched_requests_store() is called two or more times.
> The same appears with trigger_batched_requests_async_store().
> 
> This bug wasn't triggered by the tests, but observed by Dan's visual
> inspection of the code.
> 
> The recommended workaround was to return -EBUSY if test_fw_config->reqs
> is already allocated.
> 
> Fixes: c92316bf8e94 ("test_firmware: add batched firmware tests")
> Cc: Luis Chamberlain <mcgrof@...nel.org>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Russ Weight <russell.h.weight@...el.com>
> Cc: Tianfei Zhang <tianfei.zhang@...el.com>
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Colin Ian King <colin.i.king@...il.com>
> Cc: Randy Dunlap <rdunlap@...radead.org>
> Cc: linux-kselftest@...r.kernel.org
> Cc: stable@...r.kernel.org # v4.14
> Suggested-by: Dan Carpenter <error27@...il.com>
> Suggested-by: Takashi Iwai <tiwai@...e.de>
> Link: https://lore.kernel.org/r/20230509084746.48259-2-mirsad.todorovac@alu.unizg.hr
> Signed-off-by: Mirsad Todorovac <mirsad.todorovac@....unizg.hr>
> 
> [ This fix is applied against the 4.14 stable branch. There are no changes to the ]
> [ fix in code when compared to the upstread, only the reformatting for backport.  ]

Thanks for all of these, now queued up.

greg k-h