linux-kernel - Re: [PATCH] reset: ti: syscon: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH3L5QrdF3fZDKV4FvsO+czgWyWNxKZE3yaxP7C94o0oyLZ6HQ@mail.gmail.com>
Date:   Mon, 7 Aug 2023 14:57:42 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, p.zabel@...gutronix.de, afd@...com,
        s-anna@...com
Subject: Re: [PATCH] reset: ti: syscon: remove unneeded call to platform_set_drvdata()

On Mon, Aug 7, 2023 at 2:15 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

// also adding the people listed as MODULE_AUTHOR
// the list seems a bit short otherwise; no idea if these emails work

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/reset/reset-ti-syscon.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/reset/reset-ti-syscon.c b/drivers/reset/reset-ti-syscon.c
> index f0dd7ffc3b72..23f86ddb8668 100644
> --- a/drivers/reset/reset-ti-syscon.c
> +++ b/drivers/reset/reset-ti-syscon.c
> @@ -204,8 +204,6 @@ static int ti_syscon_reset_probe(struct platform_device *pdev)
>         data->controls = controls;
>         data->nr_controls = nr_controls;
>
> -       platform_set_drvdata(pdev, data);
> -
>         return devm_reset_controller_register(dev, &data->rcdev);
>  }
>
> --
> 2.34.1
>