linux-kernel - Re: [patch 00/53] x86/topology: The final installment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20230809165019.85611-1-qiuxu.zhuo@intel.com>
Date:   Thu, 10 Aug 2023 00:50:19 +0800
From:   Qiuxu Zhuo <qiuxu.zhuo@...el.com>
To:     sohil.mehta@...el.com
Cc:     andrew.cooper3@...rix.com, andy@...radead.org,
        arjan@...ux.intel.com, dimitri.sivanich@....com,
        feng.tang@...el.com, jgross@...e.com, kan.liang@...ux.intel.com,
        kprateek.nayak@....com, linux-kernel@...r.kernel.org,
        mikelley@...rosoft.com, paulmck@...nel.org, peterz@...radead.org,
        ray.huang@....com, rui.zhang@...el.com, tglx@...utronix.de,
        thomas.lendacky@....com, x86@...nel.org, qiuxu.zhuo@...el.com
Subject: Re: [patch 00/53] x86/topology: The final installment

Hi Sohil,

> From: Sohil Mehta <sohil.mehta@...el.com>
> ...
> Subject: Re: [patch 00/53] x86/topology: The final installment
> ...
> Debugfs
> -------
> # cat /sys/kernel/debug/x86/topo/cpus/39
> online:              1
> initial_apicid:      39
> apicid:              39
> ...

Did you convert the output formats of 'initial_apicid' and 'apicid'
from hexadecimal to decimal in your testing? It was really coincidental
that if the output values were '39' in hexadecimal for the CPU '39'
in decimal :-).

I noticed they were represented in hexadecimal format in
arch/x86/kernel/cpu/debugfs.c:

    seq_printf(m, "initial_apicid:      %x\n", c->topo.initial_apicid);
    seq_printf(m, "apicid:              %x\n", c->topo.apicid);

Thanks!
-Qiuxu