linux-kernel - Re: [PATCH] rtc: stm32: remove incorrect #ifdef check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 09 Aug 2023 20:24:33 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "kernel test robot" <lkp@...el.com>,
        "Arnd Bergmann" <arnd@...nel.org>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>
Cc:     oe-kbuild-all@...ts.linux.dev,
        "Alessandro Zummo" <a.zummo@...ertech.it>,
        "Maxime Coquelin" <mcoquelin.stm32@...il.com>,
        "Alexandre Torgue" <alexandre.torgue@...s.st.com>,
        "Valentin Caron" <valentin.caron@...s.st.com>,
        "Antonio Borneo" <antonio.borneo@...s.st.com>,
        "Amelie DELAUNAY" <amelie.delaunay@...s.st.com>,
        "Christophe Guibout" <christophe.guibout@...s.st.com>,
        "Gabriel Fernandez" <gabriel.fernandez@...s.st.com>,
        linux-rtc@...r.kernel.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rtc: stm32: remove incorrect #ifdef check

On Wed, Aug 9, 2023, at 18:36, kernel test robot wrote:
>
>
> If you fix the issue in a separate patch/commit (i.e. not just a new 
> version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: 
> https://lore.kernel.org/oe-kbuild-all/202308100045.WeVD1ttk-lkp@intel.com/
>
> All warnings (new ones prefixed by >>):
>
>>> drivers/rtc/rtc-stm32.c:903:12: warning: 'stm32_rtc_resume' defined but not used [-Wunused-function]
>      903 | static int stm32_rtc_resume(struct device *dev)
>          |            ^~~~~~~~~~~~~~~~
>>> drivers/rtc/rtc-stm32.c:893:12: warning: 'stm32_rtc_suspend' defined but not used [-Wunused-function]
>      893 | static int stm32_rtc_suspend(struct device *dev)
>          |            ^~~~~~~~~~~~~~~~~

This is the warning you get if my patch is applied but the
fb9a7e5360dc8 ("rtc: stm32: change PM callbacks to "_noirq()"")
commit is not. If that patch is applied, mine is needed to address
the other warning.

      Arnd