linux-kernel - Re: [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <c67fa35a-590f-404c-8104-5afbf14ad282@app.fastmail.com>
Date:   Wed, 09 Aug 2023 20:26:17 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Daniel Sneddon" <daniel.sneddon@...ux.intel.com>,
        "Arnd Bergmann" <arnd@...nel.org>, x86@...nel.org,
        "Thomas Gleixner" <tglx@...utronix.de>,
        "Ingo Molnar" <mingo@...hat.com>, "Borislav Petkov" <bp@...en8.de>,
        "Dave Hansen" <dave.hansen@...ux.intel.com>,
        "Sean Christopherson" <seanjc@...gle.com>,
        "Paolo Bonzini" <pbonzini@...hat.com>,
        "Josh Poimboeuf" <jpoimboe@...nel.org>
Cc:     "H. Peter Anvin" <hpa@...or.com>,
        "Peter Zijlstra" <peterz@...radead.org>,
        "Maxim Levitsky" <mlevitsk@...hat.com>,
        "Michal Luczaj" <mhal@...x.co>, linux-kernel@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH 2/2] x86: move gds_ucode_mitigated() declaration to header

On Wed, Aug 9, 2023, at 18:54, Daniel Sneddon wrote:
> HI Arnd,
>
> On 8/9/23 06:05, Arnd Bergmann wrote:
>> From: Arnd Bergmann <arnd@...db.de>
>> 
>> The declaration got placed in the .c file of the caller, but that
>> causes a warning for the definition:
>> 
>> arch/x86/kernel/cpu/bugs.c:682:6: error: no previous prototype for 'gds_ucode_mitigated' [-Werror=missing-prototypes]
>
> When I build with gcc 9.4 and the x86_64_defconfig I don't see this warning even
> without this patch. I'm curious why you're seeing it and I'm not. Any ideas?

The warning is currently disabled by default, unless you build with
'make W=1'. I'm in the process of getting my last patches out to
change this so the warning is enabled by default though, so I was
phrasing this based on the future behavior. Sorry if this was confusing.

    Arnd