linux-kernel - Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230809192117.h7rn6vwmvxdnkr2a@intel.intel>
Date:   Wed, 9 Aug 2023 21:21:17 +0200
From:   Andi Shyti <andi.shyti@...nel.org>
To:     Liao Chang <liaochang1@...wei.com>
Cc:     florian.fainelli@...adcom.com, rjui@...adcom.com,
        sbranden@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
        yangyicong@...ilicon.com, aisheng.dong@....com,
        shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
        festevam@...il.com, linux-imx@....com, kblaiech@...dia.com,
        asmaa@...dia.com, loic.poulain@...aro.org, rfoss@...nel.org,
        ardb@...nel.org, gcherian@...vell.com, linux-i2c@...r.kernel.org,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
        linux-arm-msm@...r.kernel.org,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe
 function

Hi Liao,

On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote:
> Use the dev_err_probe function instead of dev_err in the probe function
> so that the printed messge includes the return value and also handles
> -EPROBE_DEFER nicely.
> 
> Signed-off-by: Liao Chang <liaochang1@...wei.com>

After some discussions and time, I think it's right to r-b this
patch. If you agree more with Krzysztof, feel free to follow his
recommendation and send another version otherwise I will go ahead
and take this series in my branch. I do not really mind, both
arguments are valid.

Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 

Thanks,
Andi