linux-kernel - Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 10 Aug 2023 10:33:58 +0800
From:   "Liao, Chang" <liaochang1@...wei.com>
To:     Andi Shyti <andi.shyti@...nel.org>
CC:     <florian.fainelli@...adcom.com>, <rjui@...adcom.com>,
        <sbranden@...adcom.com>, <bcm-kernel-feedback-list@...adcom.com>,
        <yangyicong@...ilicon.com>, <aisheng.dong@....com>,
        <shawnguo@...nel.org>, <s.hauer@...gutronix.de>,
        <kernel@...gutronix.de>, <festevam@...il.com>, <linux-imx@....com>,
        <kblaiech@...dia.com>, <asmaa@...dia.com>,
        <loic.poulain@...aro.org>, <rfoss@...nel.org>, <ardb@...nel.org>,
        <gcherian@...vell.com>, <linux-i2c@...r.kernel.org>,
        <linux-rpi-kernel@...ts.infradead.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <linux-arm-msm@...r.kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v3 9/9] i2c: synquacer: Use dev_err_probe in probe
 function

Hi Andi and Krzysztof,

在 2023/8/10 3:21, Andi Shyti 写道:
> Hi Liao,
> 
> On Tue, Aug 08, 2023 at 09:29:54AM +0800, Liao Chang wrote:
>> Use the dev_err_probe function instead of dev_err in the probe function
>> so that the printed messge includes the return value and also handles
>> -EPROBE_DEFER nicely.
>>
>> Signed-off-by: Liao Chang <liaochang1@...wei.com>
> 
> After some discussions and time, I think it's right to r-b this
> patch. If you agree more with Krzysztof, feel free to follow his
> recommendation and send another version otherwise I will go ahead
> and take this series in my branch. I do not really mind, both
> arguments are valid.

I saw that Frank Li developed some new APIs that look like they would be very
helpful for aligning the error messages of devm_request_irq in device probes.
However, the patches have been pending for weeks and the author hasn't sent a
new version. So I'm not planning to switch to the new APIs in this patch series,
if there are no objections.

Do I need to resend a new revision to add your R-B at this patch?

Thanks.

> 
> Reviewed-by: Andi Shyti <andi.shyti@...nel.org> 
> 
> Thanks,
> Andi

-- 
BR
Liao, Chang