linux-kernel - Re: [PATCH] drm/amdgpu: Use local64_try_cmpxchg in amdgpu_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MCquO_Sh0RUVYATbLwS1+h2UrLHoUkCXYeF7=R4kZmDg@mail.gmail.com>
Date:   Wed, 9 Aug 2023 18:09:36 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Uros Bizjak <ubizjak@...il.com>
Cc:     amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, "Pan, Xinhui" <Xinhui.Pan@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>
Subject: Re: [PATCH] drm/amdgpu: Use local64_try_cmpxchg in amdgpu_perf_read

Applied.  Thanks!

Alex

On Mon, Jul 3, 2023 at 7:16 PM Uros Bizjak <ubizjak@...il.com> wrote:
>
> Use local64_try_cmpxchg instead of local64_cmpxchg (*ptr, old, new) == old
> in amdgpu_perf_read.  x86 CMPXCHG instruction returns success in ZF flag,
> so this change saves a compare after cmpxchg (and related move instruction
> in front of cmpxchg).
>
> Also, try_cmpxchg implicitly assigns old *ptr value to "old" when cmpxchg
> fails. There is no need to re-read the value in the loop.
>
> No functional change intended.
>
> Cc: Alex Deucher <alexander.deucher@....com>
> Cc: "Christian König" <christian.koenig@....com>
> Cc: "Pan, Xinhui" <Xinhui.Pan@....com>
> Cc: David Airlie <airlied@...il.com>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Signed-off-by: Uros Bizjak <ubizjak@...il.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> index 71ee361d0972..6e91ea1de5aa 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pmu.c
> @@ -276,9 +276,8 @@ static void amdgpu_perf_read(struct perf_event *event)
>             (!pe->adev->df.funcs->pmc_get_count))
>                 return;
>
> +       prev = local64_read(&hwc->prev_count);
>         do {
> -               prev = local64_read(&hwc->prev_count);
> -
>                 switch (hwc->config_base) {
>                 case AMDGPU_PMU_EVENT_CONFIG_TYPE_DF:
>                 case AMDGPU_PMU_EVENT_CONFIG_TYPE_XGMI:
> @@ -289,7 +288,7 @@ static void amdgpu_perf_read(struct perf_event *event)
>                         count = 0;
>                         break;
>                 }
> -       } while (local64_cmpxchg(&hwc->prev_count, prev, count) != prev);
> +       } while (!local64_try_cmpxchg(&hwc->prev_count, &prev, count));
>
>         local64_add(count - prev, &event->count);
>  }
> --
> 2.41.0
>