linux-kernel - Re: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in pltfrm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2023 15:11:40 -0700
From:   "Bao D. Nguyen" <quic_nguyenb@...cinc.com>
To:     Brian Masney <bmasney@...hat.com>, <jejb@...ux.ibm.com>,
        <martin.petersen@...cle.com>
CC:     <alim.akhtar@...sung.com>, <avri.altman@....com>,
        <bvanassche@....org>, <linux-scsi@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <hugo@...ovil.com>
Subject: Re: [PATCH v2 2/2] scsi: ufs: host: convert to dev_err_probe() in
 pltfrm_init

On 8/9/2023 12:10 PM, Brian Masney wrote:
> Convert ufshcd_pltfrm_init() over to use dev_err_probe() to avoid
> the following log message on bootup due to an -EPROBE_DEFER return
> code:
> 
>      ufshcd-qcom 1d84000.ufs: Initialization failed
> 
> Signed-off-by: Brian Masney <bmasney@...hat.com>
> ---
> No changes since v1
> 
>   drivers/ufs/host/ufshcd-pltfrm.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/ufs/host/ufshcd-pltfrm.c b/drivers/ufs/host/ufshcd-pltfrm.c
> index 0b7430033047..f2c50b78efbf 100644
> --- a/drivers/ufs/host/ufshcd-pltfrm.c
> +++ b/drivers/ufs/host/ufshcd-pltfrm.c
> @@ -373,7 +373,7 @@ int ufshcd_pltfrm_init(struct platform_device *pdev,
>   
>   	err = ufshcd_init(hba, mmio_base, irq);
>   	if (err) {
> -		dev_err(dev, "Initialization failed\n");
> +		dev_err_probe(dev, err, "Initialization failed\n");
Hi Brian,
Can you pls add the error code to the print?

>   		goto dealloc_host;
>   	}
>