linux-kernel - Re: [PATCH v3 5/7] selinux: avoid implicit conversions in selinuxfs code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <651d3c359cdfd599482a94104c35ee05.paul@paul-moore.com>
Date:   Wed, 09 Aug 2023 19:07:44 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Christian Göttsche <cgzones@...glemail.com>,
        selinux@...r.kernel.org
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/7] selinux: avoid implicit conversions in selinuxfs  code

On Aug  7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@...glemail.com> wrote:
> 
> Use umode_t as parameter type for sel_make_inode(), which assigns the
> value to the member i_mode of struct inode.
> 
> Use identical and unsigned types for loop iterators.
> 
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
> v3:
>   - drop leftover declaration in init-clauses of for loops
>   - use unsigned int instead of u32 for loop iterator with loop bounds
>     known at compile time to be small (<100)
> v2: avoid declarations in init-clauses of for loops
> ---
>  security/selinux/selinuxfs.c | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)

Merged into selinux/next, thanks.

--
paul-moore.com