linux-kernel - Re: [PATCH v3 6/7] selinux: avoid implicit conversions in policydb code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ce4baf8a868a0e8d508eb7c9499a5328.paul@paul-moore.com>
Date:   Wed, 09 Aug 2023 19:07:45 -0400
From:   Paul Moore <paul@...l-moore.com>
To:     Christian Göttsche <cgzones@...glemail.com>,
        selinux@...r.kernel.org
Cc:     Stephen Smalley <stephen.smalley.work@...il.com>,
        Eric Paris <eparis@...isplace.org>,
        Ondrej Mosnacek <omosnace@...hat.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 6/7] selinux: avoid implicit conversions in policydb  code

On Aug  7, 2023 =?UTF-8?q?Christian=20G=C3=B6ttsche?= <cgzones@...glemail.com> wrote:
> 
> Use the identical type for local variables, e.g. loop counters.
> 
> Declare members of struct policydb_compat_info unsigned to consistently
> use unsigned iterators.  They hold read-only non-negative numbers in the
> global variable policydb_compat.
> 
> Signed-off-by: Christian Göttsche <cgzones@...glemail.com>
> ---
> v3:
>   - use unsigned int instead of u32 for iterators where the loop bound
>     is known at compile time and small (<100)
>     /@...l: keep u32 iterator in policydb_destroy() due to
>     /  for (i = 0; i < p->p_types.nprim; i++)
>     /
>   - drop not mentioned protocol and port checks regarding out of range
>     values; there are a couple more of them and those changes are
>     suitable for a different patchset
> v2:
>   - avoid declarations in init-clauses of for loops
>   - declare members of struct policydb_compat_info unsigned
> ---
>  security/selinux/ss/policydb.c | 69 ++++++++++++++++++----------------
>  1 file changed, 37 insertions(+), 32 deletions(-)

Merged into selinux/next, thanks.

--
paul-moore.com