linux-kernel - Re: [PATCH] serial: sprd: Support 12 uart ports

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 9 Aug 2023 13:52:10 +0800
From:   wenhua lin <wenhua.lin1994@...il.com>
To:     Baolin Wang <baolin.wang@...ux.alibaba.com>
Cc:     Wenhua Lin <Wenhua.Lin@...soc.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Orson Zhai <orsonzhai@...il.com>,
        Chunyan Zhang <zhang.lyra@...il.com>,
        linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xiongpeng Wu <xiongpeng.wu@...soc.com>
Subject: Re: [PATCH] serial: sprd: Support 12 uart ports

The change of the max ports is to adapt to an new
SPRD serial hardware,also is backward-compatibility with old hardware.

Baolin Wang <baolin.wang@...ux.alibaba.com> 于2023年8月7日周一 16:41写道：
>
>
>
> On 8/7/2023 4:07 PM, Wenhua Lin wrote:
> > From: Wenhua Lin <wenhua.lin@...soc.com>
> >
> > Support 12 uart ports, which can solve the problem
> > of insufficient uart ports.
>
> This sounds incorrect to me.
> If this is a software bug, please add a Fixes tag to backport for stable
> kernels. If the change of the max ports is only avaliable on the new
> SPRD serial hardware, you should ensure the change is
> backward-compatibility with old hardware.
>
> > Signed-off-by: Wenhua Lin <wenhua.lin@...soc.com>
> > ---
> >   drivers/tty/serial/sprd_serial.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/sprd_serial.c b/drivers/tty/serial/sprd_serial.c
> > index b58f51296ace..2774df490899 100644
> > --- a/drivers/tty/serial/sprd_serial.c
> > +++ b/drivers/tty/serial/sprd_serial.c
> > @@ -22,7 +22,7 @@
> >   #include <linux/tty_flip.h>
> >
> >   /* device name */
> > -#define UART_NR_MAX          8
> > +#define UART_NR_MAX          12
> >   #define SPRD_TTY_NAME               "ttyS"
> >   #define SPRD_FIFO_SIZE              128
> >   #define SPRD_DEF_RATE               26000000