linux-kernel - Re: [PATCH v2] pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2e9c9e03-bc25-9c37-2a91-0fbf75d500a4@quicinc.com>
Date:   Wed, 9 Aug 2023 15:27:25 +0530
From:   Ninad Naik <quic_ninanaik@...cinc.com>
To:     Andrew Halaney <ahalaney@...hat.com>,
        Bjorn Andersson <andersson@...nel.org>
CC:     <agross@...nel.org>, <konrad.dybcio@...aro.org>,
        <linux-arm-msm@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <quic_ppareek@...cinc.com>,
        <psodagud@...cinc.com>, <quic_kprasan@...cinc.com>,
        <quic_ymg@...cinc.com>, Bjorn Andersson <quic_bjorande@...cinc.com>
Subject: Re: [PATCH v2] pinctrl: qcom: Add intr_target_width field to support
 increased number of interrupt targets



On 8/9/2023 2:36 AM, Andrew Halaney wrote:
> On Tue, Jul 18, 2023 at 08:32:59AM -0700, Bjorn Andersson wrote:
>> On Tue, Jul 18, 2023 at 12:12:46PM +0530, Ninad Naik wrote:
>>> SA8775 and newer target have added support for an increased number of
>>> interrupt targets. To implement this change, the intr_target field, which
>>> is used to configure the interrupt target in the interrupt configuration
>>> register is increased from 3 bits to 4 bits.
>>>
>>> In accordance to these updates, a new intr_target_width member is
>>> introduced in msm_pingroup structure. This member stores the value of
>>> width of intr_target field in the interrupt configuration register. This
>>> value is used to dynamically calculate and generate mask for setting the
>>> intr_target field. By default, this mask is set to 3 bit wide, to ensure
>>> backward compatibility with the older targets.
>>>
>>> Changes in v2 :
>>> -----------------
>>> - Changed initial definition of intr_target_mask variable to use GENMASK().
>>> - Update commit subject appropiately.
>>> - Add Fixes tag.
>>> - v1 : https://lore.kernel.org/all/20230714061010.15817-1-quic_ninanaik@quicinc.com/
>>
>> Thanks for adding a good changelog, very much appreciated. The changelog
>> should be added below the '---' line though, as it typically don't add
>> value to the git history (except drivers/gpu/* which wants it here...).
>>
>> Perhaps Linus can drop it as he applies the patch, no need to resubmit
>> unless he ask you to.
>>
>> Thanks,
>> Bjorn
>>
> 
> Gentle ping on this one... but then I realized that linusw isn't CC'ed
> on this patch directly, and I'm unsure of what the workflow is for
> pinctrl. ./scripts/get_maintainer.pl shows he should have been in the CC
> list ideally :)
> 
> Maybe send a v3 with the changelog dropped from the actual message (i.e.
> follow Bjorn's advice), and make sure to include the folks
> get_maintainer tells you to so this gets picked up (or maybe just saying
> Linus' name will make him appear out of the woodworks if we're lucky):
My bad on this one, I'll immediately send a v3 along with addressing the 
changelog suggestion mentioned by Bjorn.
> 
>      ahalaney@...ora ~/git/linux-next (git)-[7de73ad15b73] % b4 am 20230718064246.12429-1-quic_ninanaik@...cinc.com
>      Grabbing thread from lore.kernel.org/all/20230718064246.12429-1-quic_ninanaik@...cinc.com/t.mbox.gz
>      Analyzing 3 messages in the thread
>      Checking attestation on all messages, may take a moment...
>      ---
>        ✓ [PATCH v2] pinctrl: qcom: Add intr_target_width field to support increased number of interrupt targets
>        ---
>        ✓ Signed: DKIM/quicinc.com
>      ---
>      Total patches: 1
>      ---
>       Link: https://lore.kernel.org/r/20230718064246.12429-1-quic_ninanaik@quicinc.com
>       Base: applies clean to current tree
>             git checkout -b v2_20230718_quic_ninanaik_quicinc_com HEAD
>             git am ./v2_20230718_quic_ninanaik_pinctrl_qcom_add_intr_target_width_field_to_support_increased_number_of_in.mbx
>      ahalaney@...ora ~/git/linux-next (git)-[7de73ad15b73] % ./scripts/get_maintainer.pl ./v2_20230718_quic_ninanaik_pinctrl_qcom_add_intr_target_width_field_to_support_increased_number_of_in.mbx
>      Andy Gross <agross@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
>      Bjorn Andersson <andersson@...nel.org> (maintainer:ARM/QUALCOMM SUPPORT)
>      Konrad Dybcio <konrad.dybcio@...aro.org> (maintainer:ARM/QUALCOMM SUPPORT,blamed_fixes:1/1=100%)
>      Linus Walleij <linus.walleij@...aro.org> (maintainer:PIN CONTROL SUBSYSTEM,blamed_fixes:1/1=100%)
>      Bartosz Golaszewski <bartosz.golaszewski@...aro.org> (blamed_fixes:1/1=100%)
>      Yadu MG <quic_ymg@...cinc.com> (blamed_fixes:1/1=100%)
>      Prasad Sodagudi <quic_psodagud@...cinc.com> (blamed_fixes:1/1=100%)
>      linux-arm-msm@...r.kernel.org (open list:ARM/QUALCOMM SUPPORT)
>      linux-gpio@...r.kernel.org (open list:PIN CONTROL SUBSYSTEM)
>      linux-kernel@...r.kernel.org (open list)
>      ahalaney@...ora ~/git/linux-next (git)-[7de73ad15b73] %
> 
> I'm eager to get this fix in so I can describe a missing IRQ or two
> wrt ethernet GPIOs and submit that without stating the dependency
> on this fix! :)
> 
> Thanks,
> Andrew
> 
Thanks,
Ninad