linux-kernel - Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation Library

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a64fe3ad-cb2a-3816-fefe-700433926492@redhat.com>
Date:   Wed, 9 Aug 2023 16:38:00 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Yazen Ghannam <yazen.ghannam@....com>,
        Borislav Petkov <bp@...en8.de>,
        "Limonciello, Mario" <mario.limonciello@....com>,
        linux-edac@...r.kernel.org, markgross@...nel.org,
        platform-driver-x86@...r.kernel.org,
        "Luck, Tony" <tony.luck@...el.com>
Cc:     linux-kernel@...r.kernel.org, avadhut.naik@....com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation
 Library

Hi,

On 8/8/23 16:07, Yazen Ghannam wrote:
> On 8/8/2023 8:10 AM, Borislav Petkov wrote:
>> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" <mario.limonciello@....com> wrote:
>>> Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/?  There's plenty of library code there as tristate.
>>
>> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules.
>>
> 
> There are modules in arch/x86, so I guess that's not an issue (not sure what I was thinking).

Right, I think arch/x86 makes sense.

As for putting this under drivers/platform/x86/amd as initially suggested. That means that any code which wants to select this because it needs the functions also must select X86_PLATFORM_DEVICES, so IMHO it is better to put it in another place.

Regards,

Hans