[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <5b3c306a-059d-479f-8ad0-c914de8a2def@amd.com>
Date: Wed, 9 Aug 2023 11:05:51 -0400
From: Yazen Ghannam <yazen.ghannam@....com>
To: Hans de Goede <hdegoede@...hat.com>,
Borislav Petkov <bp@...en8.de>,
"Limonciello, Mario" <mario.limonciello@....com>,
linux-edac@...r.kernel.org, markgross@...nel.org,
platform-driver-x86@...r.kernel.org,
"Luck, Tony" <tony.luck@...el.com>
Cc: yazen.ghannam@....com, linux-kernel@...r.kernel.org,
avadhut.naik@....com
Subject: Re: [PATCH 1/2] platform/x86/amd: Introduce AMD Address Translation
Library
On 8/9/2023 10:38 AM, Hans de Goede wrote:
> Hi,
>
> On 8/8/23 16:07, Yazen Ghannam wrote:
>> On 8/8/2023 8:10 AM, Borislav Petkov wrote:
>>> On August 8, 2023 5:17:33 AM GMT+02:00, "Limonciello, Mario" <mario.limonciello@....com> wrote:
>>>> Given it's 'library code' to be used by a bunch of things and also want to be able to use a module, what about putting it in lib/? There's plenty of library code there as tristate.
>>>
>>> It is x86-specific so not in there. Also, it might be used by multiple things so you want it as a separate "translation" service which is called by other modules.
>>>
>>
>> There are modules in arch/x86, so I guess that's not an issue (not sure what I was thinking).
>
> Right, I think arch/x86 makes sense.
>
> As for putting this under drivers/platform/x86/amd as initially suggested. That means that any code which wants to select this because it needs the functions also must select X86_PLATFORM_DEVICES, so IMHO it is better to put it in another place.
>
Good point, and thanks for your feedback!
Thanks,
Yazen
Powered by blists - more mailing lists