[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <fb1cc561-926e-478d-a6ce-9d97fa0dd0e1@kadam.mountain>
Date: Thu, 10 Aug 2023 07:59:15 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Andrei Coardos <aboutphysycs@...il.com>
Cc: linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
linux-tegra@...r.kernel.org, ac100@...ts.launchpad.net,
gregkh@...uxfoundation.org, marvin24@....de, alex@...uggie.ro
Subject: Re: [PATCH] staging: nvec: paz00: remove unneeded call to
platform_set_drvdata()
On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>
> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
I think you are right, but why are we doing this? That one line is
hardly a huge eyesore. It's all risk and no reward.
Have you tested this change on real hardware?
regards,
dan carpenter
Powered by blists - more mailing lists