linux-kernel - Re: [PATCH] staging: nvec: paz00: remove unneeded call to platform_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d772f63c-ed2d-ce3a-e466-eb2d2d46f700@gmx.de>
Date:   Sun, 20 Aug 2023 22:47:54 +0200 (CEST)
From:   Marc Dietrich <marvin24@....de>
To:     Dan Carpenter <dan.carpenter@...aro.org>
cc:     Andrei Coardos <aboutphysycs@...il.com>,
        linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev,
        linux-tegra@...r.kernel.org, ac100@...ts.launchpad.net,
        gregkh@...uxfoundation.org, marvin24@....de, alex@...uggie.ro
Subject: Re: [PATCH] staging: nvec: paz00: remove unneeded call to
 platform_set_drvdata()

Hi,

On Thu, 10 Aug 2023, Dan Carpenter wrote:

> On Wed, Aug 09, 2023 at 06:42:11PM +0300, Andrei Coardos wrote:
>> This function call was found to be unnecessary as there is no equivalent
>> platform_get_drvdata() call to access the private data of the driver. Also,
>> the private data is defined in this driver, so there is no risk of it being
>> accessed outside of this driver file.
>>
>> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
>> ---
>
> I think you are right, but why are we doing this?  That one line is
> hardly a huge eyesore.  It's all risk and no reward.

I guess this was placed in order to implement a module unload function,
but this was never done. The driver also seems to have found another
method to get its private data, so this can be safely removed.

> Have you tested this change on real hardware?

I just checked that it compiles and works on my AC100.

Thanks!

Marc