linux-kernel - Re: [PATCH drm-misc-next] drm/test: drm_exec: fix memory leak on object prepare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <37a235d0-3da1-85c3-766d-29fd31d8a797@amd.com>
Date:   Thu, 10 Aug 2023 09:03:16 +0200
From:   Christian König <christian.koenig@....com>
To:     Danilo Krummrich <dakr@...hat.com>, airlied@...il.com,
        daniel@...ll.ch, alexander.deucher@....com, arthurgrillo@...eup.net
Cc:     dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH drm-misc-next] drm/test: drm_exec: fix memory leak on
 object prepare

Am 10.08.23 um 00:50 schrieb Danilo Krummrich:
> drm_exec_prepare_obj() and drm_exec_prepare_array() both reserve
> dma-fence slots and hence a dma_resv_list without ever freeing it.
>
> Make sure to call drm_gem_private_object_fini() for each GEM object
> passed to drm_exec_prepare_obj()/drm_exec_prepare_array() throughout the
> test to fix this up.
>
> While at it, remove some trailing empty lines.
>
> Fixes: 9710631cc8f3 ("drm: add drm_exec selftests v4")
> Signed-off-by: Danilo Krummrich <dakr@...hat.com>

Reviewed and pushed to drm-misc-next.

Thanks,
Christian.

> ---
>   drivers/gpu/drm/tests/drm_exec_test.c | 7 +++++--
>   1 file changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tests/drm_exec_test.c b/drivers/gpu/drm/tests/drm_exec_test.c
> index f79c9f0359aa..9ccf0dd9ca89 100644
> --- a/drivers/gpu/drm/tests/drm_exec_test.c
> +++ b/drivers/gpu/drm/tests/drm_exec_test.c
> @@ -125,8 +125,6 @@ static void test_duplicates(struct kunit *test)
>   	drm_exec_fini(&exec);
>   }
>   
> -
> -
>   static void test_prepare(struct kunit *test)
>   {
>   	struct drm_exec_priv *priv = test->priv;
> @@ -145,6 +143,8 @@ static void test_prepare(struct kunit *test)
>   			break;
>   	}
>   	drm_exec_fini(&exec);
> +
> +	drm_gem_private_object_fini(&gobj);
>   }
>   
>   static void test_prepare_array(struct kunit *test)
> @@ -165,6 +165,9 @@ static void test_prepare_array(struct kunit *test)
>   					     1);
>   	KUNIT_EXPECT_EQ(test, ret, 0);
>   	drm_exec_fini(&exec);
> +
> +	drm_gem_private_object_fini(&gobj1);
> +	drm_gem_private_object_fini(&gobj2);
>   }
>   
>   static struct kunit_case drm_exec_tests[] = {
>
> base-commit: e05f3938c5a7896d09736e3381675a57ffee7a0a