linux-kernel - Re: [PATCH 2/6] soc: qcom: llcc: Refactor llcc driver to support multiple configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79ccb7c0-dc4b-87a7-3721-488f3ef3b192@linaro.org>
Date:   Thu, 10 Aug 2023 13:22:25 +0100
From:   Bryan O'Donoghue <bryan.odonoghue@...aro.org>
To:     Komal Bajaj <quic_kbajaj@...cinc.com>, agross@...nel.org,
        andersson@...nel.org, konrad.dybcio@...aro.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        srinivas.kandagatla@...aro.org
Cc:     linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/6] soc: qcom: llcc: Refactor llcc driver to support
 multiple configuration

On 10/08/2023 07:11, Komal Bajaj wrote:
> +	if (!cfgs || cfgs->num_config != DEF_NUM_CFG) {
> +		ret = -EINVAL;
> +		goto err;
> +	}
> +	cfg = &cfgs->llcc_config[DEF_NUM_CFG - 1];

This is a bit of a redundant check.

You add in the check for num_config != 1, then deref llc_config[0] but 
in patch #4 you get an index and check that index against num_config

I'm not seeing how at this point in your series, how num_config could be 
anything other than 1.

I'd do away with the DEF_NUM_CFG define in this code/series completely.

num_config should encode all the necessary detail we need, DEF_NUM_CFG 
just adds noise.

---
bod