linux-kernel - Re: [PATCH] tpm/tpm_tis: Disable interrupts categorically for Lenovo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 11 Aug 2023 19:51:27 +0300
From:   "Jarkko Sakkinen" <jarkko@...nel.org>
To:     "Takashi Iwai" <tiwai@...e.de>
Cc:     <linux-integrity@...r.kernel.org>,
        "Linus Torvalds" <torvalds@...ux-foundation.org>,
        <stable@...r.kernel.org>,
        "Lino Sanfilippo" <l.sanfilippo@...bus.com>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tpm/tpm_tis: Disable interrupts categorically for
 Lenovo

On Fri Aug 11, 2023 at 6:26 PM EEST, Takashi Iwai wrote:
> On Fri, 11 Aug 2023 09:21:09 +0200,
> Takashi Iwai wrote:
> > 
> > On Thu, 10 Aug 2023 20:24:33 +0200,
> > Jarkko Sakkinen wrote:
> > > 
> > > By large most of the entries in tpm_tis_dmi_table[] are for Lenovo laptops,
> > > and they keep on coming. Therefore, disable IRQs categorically for Lenovo.
> > > 
> > > Fixes: e644b2f498d2 ("tpm, tpm_tis: Enable interrupt test")
> > > Cc: <stable@...r.kernel.org> # v6.4+
> > > Reported-by: "Takashi Iwai" <tiwai@...e.de>
> > > Closes: https://lore.kernel.org/linux-integrity/87il9qhxjq.wl-tiwai@suse.de/
> > > Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
> > > ---
> > > This will be included into v6.5-rc6 PR, as long as Takashi ack's it. I'm
> > > planning to send tomorrow morning (GMT+3).
> > 
> > Feel free to take my ack:
> > 
> > Acked-by: Takashi Iwai <tiwai@...e.de>
> > 
> > I'll build a test kernel and ask reporters for testing the fix, too.
>
> FYI, the test results are all positive, so far.

Thanks a lot.

Can you check this that it looks good to you:

https://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd.git/commit/?h=next&id=bfc4b8c073a6dcfd39d413a7fa1c5ce1ede9f326

Tested-by?

BR, Jarkko