linux-kernel - Re: [PATCH v2] hv_balloon: Update the balloon driver to use the SBRM API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZNajAHD7KLfwR140@liuwe-devbox-debian-v2>
Date:   Fri, 11 Aug 2023 21:07:12 +0000
From:   Wei Liu <wei.liu@...nel.org>
To:     levymitchell0@...il.com
Cc:     "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        linux-hyperv@...r.kernel.org, linux-kernel@...r.kernel.org,
        mikelley@...rosoft.com, peterz@...radead.org,
        Boqun Feng <boqun.feng@...il.com>
Subject: Re: [PATCH v2] hv_balloon: Update the balloon driver to use the SBRM
 API

On Mon, Aug 07, 2023 at 11:55:47PM +0000, Mitchell Levy via B4 Relay wrote:
> From: Mitchell Levy <levymitchell0@...il.com>
> 
> This patch is intended as a proof-of-concept for the new SBRM
> machinery[1]. For some brief background, the idea behind SBRM is using
> the __cleanup__ attribute to automatically unlock locks (or otherwise
> release resources) when they go out of scope, similar to C++ style RAII.
> This promises some benefits such as making code simpler (particularly
> where you have lots of goto fail; type constructs) as well as reducing
> the surface area for certain kinds of bugs.
> 
> The changes in this patch should not result in any difference in how the
> code actually runs (i.e., it's purely an exercise in this new syntax
> sugar). In one instance SBRM was not appropriate, so I left that part
> alone, but all other locking/unlocking is handled automatically in this
> patch.
> 
> [1] https://lore.kernel.org/all/20230626125726.GU4253@hirez.programming.kicks-ass.net/
> 
> Suggested-by: Boqun Feng <boqun.feng@...il.com>
> Signed-off-by: "Mitchell Levy (Microsoft)" <levymitchell0@...il.com>
> Reviewed-by: Boqun Feng <boqun.feng@...il.com>

Applied to hyperv-next. Thanks!