linux-kernel - Re: [PATCH v3 0/5] Add R5F and C7x DSP nodes for J721S2 SoC.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230811211450.psoe6wjvncwxoqe2@enlarged>
Date:   Fri, 11 Aug 2023 16:14:50 -0500
From:   Nishanth Menon <nm@...com>
To:     Andrew Davis <afd@...com>
CC:     Apurva Nandan <a-nandan@...com>,
        Vignesh Raghavendra <vigneshr@...com>,
        Tero Kristo <kristo@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Conor Dooley <conor+dt@...nel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        Hari Nagalla <hnagalla@...com>, Udit Kumar <u-kumar1@...com>
Subject: Re: [PATCH v3 0/5] Add R5F and C7x DSP nodes for J721S2 SoC.

On 15:31-20230811, Andrew Davis wrote:
> On 8/11/23 3:22 PM, Apurva Nandan wrote:
> > This series adds the R5F processor nodes and C7x DSP nodes for
> > J721S2 SoC.
> > 
> > The first three patches adds the remote proc nodes to the SoC device
> > tree and the last two patches reserves the memory for remote proc IPCs
> > on J721S2 EVM board.
> > 
> > Test log: https://gist.githubusercontent.com/apurvanandan1997/556b4148651ae74b50dda993ad07f1e5/raw/
> > 
> > v3: Changelog:
> > 1) Disabled c7x in k3-j721s2-main.dtsi and enabled in k3-j721s2-som-p0.dtsi
> >     which fixes the following dtbs_check for k3-am69-sk.dts
> >     - dsp@...00000: 'mboxes' is a required property
> >     - dsp@...00000: 'memory-region' is a required property
> > 2) Split into separate patches for C7x and R5F
> 
> Thanks for taking care of these details, series LGTM,
> 
> Reviewed-by: Andrew Davis <afd@...com>
> 
> > 
> > Link to v2:
> > https://lore.kernel.org/lkml/20230808201842.292911-1-a-nandan@ti.com/
> > 
> > v2:Changelog:
> > 1) Added status = "disabled"; in soc dtsi files, and removed it from som dts
> > 2) Fixed mboxes property in for all cores in som dts
> > 
> > Link to v1:
> > https://lore.kernel.org/all/20230529220941.10801-1-hnagalla@ti.com/
> > 
> > Apurva Nandan (4):
> >    arm64: dts: ti: k3-j721s2-main: Add MAIN R5F remote processsor nodes
> >    arm64: dts: ti: k3-j721s2-main: Add C7x remote processsor nodes
> >    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> >      R5F
> >    arm64: dts : ti: k3-j721s2-som-p0: Add DDR carveout memory nodes for
> >      C71x DSPs
> > 
> > Hari Nagalla (1):
> >    arm64: dts: ti: k3-j721s2-mcu: Add MCU R5F cluster nodes

We are still missing arch/arm64/boot/dts/ti/k3-am68-sk-som.dtsi which is
a TI product.

So, lets hold this series off from the immediate merge set at least.

> > 
> >   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi    | 106 +++++++++
> >   .../boot/dts/ti/k3-j721s2-mcu-wakeup.dtsi     |  40 ++++
> >   arch/arm64/boot/dts/ti/k3-j721s2-som-p0.dtsi  | 208 ++++++++++++++++++
> >   3 files changed, 354 insertions(+)
> > 

-- 
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3  1A34 DDB5 849D 1736 249D