linux-kernel - Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node with bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7116b473-7f22-43df-af39-81e5f6db4507@linaro.org>
Date:   Sat, 12 Aug 2023 00:56:48 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     agross@...nel.org, andersson@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] ARM: dts: qcom: ipq4019-ap.dk01.1: align flash node
 with bindings

On 11.08.2023 23:35, Robert Marko wrote:
> On Fri, 11 Aug 2023 at 23:28, Konrad Dybcio <konrad.dybcio@...aro.org> wrote:
>>
>> On 11.08.2023 23:01, Robert Marko wrote:
>>> Rename the SPI-NOR node to flash@0, remove #address-cells and #size-cells
>>> as they should be under the partitions subnode and use the generic
>>> jedec,spi-nor compatible.
>>>
>>> Signed-off-by: Robert Marko <robimarko@...il.com>
>>> ---
>> You can also do "nandmanufacturer,mx25l25635e", "jedec,spi-nor"
> 
> Hi,
> I grepped the vendor U-Boot to make sure it's not being triggered off
> the mx25l25635e
> compatible but the only hit is the IC support itself.
> MX25L25635 was just the original NOR IC Qualcomm used on the board so
> to me it made
> most sense to just use the JEDEC compatible as NOR itself is JEDEC NOR
> compatible.
OK if dynamic identification works fine

Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>

Konrad