lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAH3L5QpyQejK6H_FDW1akzd8Tn3T0WbKHsKEbmHcA2R9y+W2cA@mail.gmail.com>
Date:   Fri, 11 Aug 2023 08:59:28 +0300
From:   Alexandru Ardelean <alex@...uggie.ro>
To:     Andrei Coardos <aboutphysycs@...il.com>
Cc:     linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
        rui.zhang@...el.com, amitk@...nel.org, daniel.lezcano@...aro.org,
        rafael@...nel.org
Subject: Re: [PATCH] thermal: k3_bandgap: remove unneeded call to platform_set_drvdata()

On Thu, Aug 10, 2023 at 2:23 PM Andrei Coardos <aboutphysycs@...il.com> wrote:
>
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver. Also,
> the private data is defined in this driver, so there is no risk of it being
> accessed outside of this driver file.
>

Reviewed-by: Alexandru Ardelean <alex@...uggie.ro>

> Signed-off-by: Andrei Coardos <aboutphysycs@...il.com>
> ---
>  drivers/thermal/k3_bandgap.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/thermal/k3_bandgap.c b/drivers/thermal/k3_bandgap.c
> index 1c3e590157ec..f985f36f2123 100644
> --- a/drivers/thermal/k3_bandgap.c
> +++ b/drivers/thermal/k3_bandgap.c
> @@ -225,7 +225,6 @@ static int k3_bandgap_probe(struct platform_device *pdev)
>                 devm_thermal_add_hwmon_sysfs(dev, data[id].tzd);
>         }
>
> -       platform_set_drvdata(pdev, bgp);
>
>         return 0;
>
> --
> 2.34.1
>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ