linux-kernel - Re: [PATCH blktests v2 05/12] nvme/{041,042,043,044,045,048}: Remove local variable hostnqn and hostid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <lbjgs7ebcywpk2nyli37pgpco2xgbprq7jexm7oksv2dbrofam@u6gbtsmcqw3j>
Date:   Fri, 11 Aug 2023 06:02:04 +0000
From:   Shinichiro Kawasaki <shinichiro.kawasaki@....com>
To:     Daniel Wagner <dwagner@...e.de>
CC:     "linux-nvme@...ts.infradead.org" <linux-nvme@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        Chaitanya Kulkarni <kch@...dia.com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        Hannes Reinecke <hare@...e.de>,
        Sagi Grimberg <sagi@...mberg.me>,
        James Smart <jsmart2021@...il.com>,
        Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH blktests v2 05/12] nvme/{041,042,043,044,045,048}: Remove
 local variable hostnqn and hostid

On Aug 10, 2023 / 13:13, Daniel Wagner wrote:
> Commit acc408477e85 ("nvme/{041,042,043,044,045,048}: Use default
> hostnqn and hostid") switched the test over to use the default
> hostnqn. It missed the change to remove the local variable and
> use the def_hostnqn/def_hostid directly.
> 
> Signed-off-by: Daniel Wagner <dwagner@...e.de>
> ---
[...]
> diff --git a/tests/nvme/043 b/tests/nvme/043
> index 3dc543fd55d3..5569a7a58ad5 100755
> --- a/tests/nvme/043
> +++ b/tests/nvme/043
> @@ -26,18 +26,13 @@ test() {
>  	_setup_nvmet
>  
>  	local port
> -	local subsys_name="blktests-subsystem-1"
> -	local hostid
> -	local hostnqn
>  	local file_path="${TMPDIR}/img"
>  	local hash
>  	local dhgroup
>  	local hostkey
>  	local ctrldev
>  
> -	hostid="${def_hostid}"
> -	hostnqn="${def_hostnqn}"
> -	hostkey="$(nvme gen-dhchap-key -n ${subsys_name} 2> /dev/null)"
> +	hostkey="$(nvme gen-dhchap-key -n ${def_hostnqn} 2> /dev/null)"

This part changes the -n option value from ${subsys_name} to ${def_hostnqn}.
According to "man nvme-gen-dhchap-key", this fix looks valid for me. It would be
the better to note it in the commit message for clarification, even though it is
a minor fix.