[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZNX+bponlicM3AFL@smile.fi.intel.com>
Date: Fri, 11 Aug 2023 12:25:02 +0300
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Yury Norov <yury.norov@...il.com>
Cc: linux-kernel@...r.kernel.org,
Rasmus Villemoes <linux@...musvillemoes.dk>
Subject: Re: [PATCH v2 2/6] bitmap: replace _reg_op(REG_OP_ALLOC) with
bitmap_set()
On Thu, Aug 10, 2023 at 05:57:28PM -0700, Yury Norov wrote:
> _reg_op(REG_OP_ALLOC) duplicates bitmap_set(). Fix it.
...
> int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order)
> {
> + unsigned int nbits = pos + BIT(order);
Shouldn't this be unsigned long?
As the prototype of the used later unsigned long find_next_bit().
> if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE))
> return -EBUSY;
> - return __reg_op(bitmap, pos, order, REG_OP_ALLOC);
> + bitmap_set(bitmap, pos, nbits);
> + return 0;
> }
--
With Best Regards,
Andy Shevchenko
Powered by blists - more mailing lists