linux-kernel - Re: [PATCH 1/3] md raid1: allow writebehind to work on any leg device set WriteMostly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1b42c6ba-168d-4764-1eba-3f7050883e69@huaweicloud.com>
Date:   Fri, 11 Aug 2023 09:14:49 +0800
From:   Yu Kuai <yukuai1@...weicloud.com>
To:     heinzm@...hat.com, linux-kernel@...r.kernel.org,
        linux-raid@...r.kernel.org
Cc:     ncroxon@...hat.com, xni@...hat.com,
        "yukuai (C)" <yukuai3@...wei.com>
Subject: Re: [PATCH 1/3] md raid1: allow writebehind to work on any leg device
 set WriteMostly

Hi,

在 2023/08/10 20:11, heinzm@...hat.com 写道:
> From: heinzm <heinzm@...hat.com>
> 
> As the WriteMostly flag can be set on any component device of a RAID1 array,
> remove the constraint that it only works if set on the first one.
> 
> Signed-off-by: heinzm <heinzm@...hat.com>
> ---
>   drivers/md/raid1.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index dd25832eb045..913cd46b786b 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1519,7 +1519,7 @@ static void raid1_write_request(struct mddev *mddev, struct bio *bio,
>   			 * allocate memory, or a reader on WriteMostly
>   			 * is waiting for behind writes to flush */
>   			if (bitmap &&
> -			    test_bit(WriteMostly, &rdev->flags) &&
> +			    write_behind &&

No need for a new line now.

Reviewed-by: Yu Kuai <yukuai3@...wei.com>

Thanks
>   			    (atomic_read(&bitmap->behind_writes)
>   			     < mddev->bitmap_info.max_write_behind) &&
>   			    !waitqueue_active(&bitmap->behind_wait)) {
>