linux-kernel - Re: [PATCH 0/3] md raid1: Fix writebehind/writemostly

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPhsuW7Huk5aEzVwGjyjHQhZ88N+Fyprdwb3jZ+0oNyBc23TUw@mail.gmail.com>
Date:   Sun, 13 Aug 2023 21:56:56 +0400
From:   Song Liu <song@...nel.org>
To:     heinzm@...hat.com
Cc:     linux-kernel@...r.kernel.org, linux-raid@...r.kernel.org,
        ncroxon@...hat.com, xni@...hat.com
Subject: Re: [PATCH 0/3] md raid1: Fix writebehind/writemostly

On Thu, Aug 10, 2023 at 4:12 PM <heinzm@...hat.com> wrote:
>
> From: heinzm <heinzm@...hat.com>
>
> Writemostly was only respected if set on the first leg.
>
> Set on any other leg(s) but not on the first one did
> not enable writebehind at all.
>
> Fix changes the logic using the already defind bool writebehind.
>
> Whilst on this, also make first_clone a bool as write_behind for
> consistency and add an empty line.
>
> Patches pass the MD test suite.
>
> heinzm (3):
>   md raid1: allow writebehind to work on any leg device set WriteMostly

1/3 looks good. But please resend with your full name.

>   md raid1: make first_clone a bool
>   md raid1: add empty line

2/3 and 3/3 are not necessary. I would rather keep git-blame clean.

Thanks,
Song
>
> Signed-off-by: Heinz Mauelshagen <heinzm@...hat.com>
> Tested-by: Xia Ni <xni@...hat.com>
>
>  drivers/md/raid1.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> --
> 2.41.0
>