[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <b99d2ac9-e6cd-9cea-a8a6-79c21d756139@oracle.com>
Date: Fri, 11 Aug 2023 11:08:36 +0100
From: John Garry <john.g.garry@...cle.com>
To: Ilkka Koskinen <ilkka@...amperecomputing.com>
Cc: Ian Rogers <irogers@...gle.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Will Deacon <will@...nel.org>,
James Clark <james.clark@....com>,
Mike Leach <mike.leach@...aro.org>,
Leo Yan <leo.yan@...aro.org>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...nel.org>,
Namhyung Kim <namhyung@...nel.org>,
Adrian Hunter <adrian.hunter@...el.com>,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-perf-users@...r.kernel.org,
Dave Kleikamp <dave.kleikamp@...cle.com>
Subject: Re: [PATCH 2/4] perf vendor events arm64: AmpereOne: Mark affected
STALL_* events impacted by errata
On 10/08/2023 23:38, Ilkka Koskinen wrote:
>>> why end with a '-'?
>>
>> That's a great question! I wish, I remembered why I did that. Looking
>> at other events with Errata field, they use '.'. I can fix those and
>> submit the patchset again.
>
> John, I took a look at it and it seems that if I use '.', perf will
> remove it. Here are two examples:
>
> metrics.json:
> "BriefDescription": "Impacted by errata, use metrics instead."
>
> # perf list
> [Impacted by errata, use metrics instead Spec update: Errata AC03_CPU_29]
>
> vs.
>
> "BriefDescription": "Impacted by errata, use metrics instead -"
>
> # perf list
>
> Impacted by errata, use metrics instead - Spec update: Errata AC03_CPU_29
ah, ok. I am not sure where the '.' removal is coming from.
>
> ---
>
> So, I believe, I probably used the hyphen to make the 'perf list' output
> a little "prettier". Well, I just change to dot and it's fine.
Fine. Or we could consider changing the 'perf list' formatting code to
add this '-' or similar automatically.
Thanks,
John
Powered by blists - more mailing lists