linux-kernel - Re: [PATCH 16/36] tty: use u8 for chars

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <27366cad-30b2-e326-8d8f-c6fe17cf4899@linux.intel.com>
Date:   Fri, 11 Aug 2023 13:28:56 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     "Jiri Slaby (SUSE)" <jirislaby@...nel.org>
cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-serial <linux-serial@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        William Hubbs <w.d.hubbs@...il.com>,
        Chris Brannon <chris@...-brannons.com>,
        Kirk Reiser <kirk@...sers.ca>,
        Samuel Thibault <samuel.thibault@...-lyon.org>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Arnd Bergmann <arnd@...db.de>, Max Staudt <max@...as.org>,
        Wolfgang Grandegger <wg@...ndegger.com>,
        Marc Kleine-Budde <mkl@...gutronix.de>,
        "David S. Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Dario Binacchi <dario.binacchi@...rulasolutions.com>,
        Andreas Koensgen <ajk@...nets.uni-bremen.de>,
        Jeremy Kerr <jk@...econstruct.com.au>,
        Matt Johnston <matt@...econstruct.com.au>,
        Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Peter Ujfalusi <peter.ujfalusi@...il.com>
Subject: Re: [PATCH 16/36] tty: use u8 for chars

On Thu, 10 Aug 2023, Jiri Slaby (SUSE) wrote:

> This makes all those 'unsigned char's an explicit 'u8'. This is part of
> the continuing unification of chars and flags to be consistent u8.
> 
> This approaches tty_port_default_receive_buf(). Flags to be next.
> 
> Signed-off-by: Jiri Slaby (SUSE) <jirislaby@...nel.org>
> Cc: William Hubbs <w.d.hubbs@...il.com>
> Cc: Chris Brannon <chris@...-brannons.com>
> Cc: Kirk Reiser <kirk@...sers.ca>
> Cc: Samuel Thibault <samuel.thibault@...-lyon.org>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Arnd Bergmann <arnd@...db.de>
> Cc: Max Staudt <max@...as.org>
> Cc: Wolfgang Grandegger <wg@...ndegger.com>
> Cc: Marc Kleine-Budde <mkl@...gutronix.de>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Eric Dumazet <edumazet@...gle.com>
> Cc: Jakub Kicinski <kuba@...nel.org>
> Cc: Paolo Abeni <pabeni@...hat.com>
> Cc: Dario Binacchi <dario.binacchi@...rulasolutions.com>
> Cc: Andreas Koensgen <ajk@...nets.uni-bremen.de>
> Cc: Jeremy Kerr <jk@...econstruct.com.au>
> Cc: Matt Johnston <matt@...econstruct.com.au>
> Cc: Liam Girdwood <lgirdwood@...il.com>
> Cc: Mark Brown <broonie@...nel.org>
> Cc: Jaroslav Kysela <perex@...ex.cz>
> Cc: Takashi Iwai <tiwai@...e.com>
> Cc: Peter Ujfalusi <peter.ujfalusi@...il.com>
> ---
>  drivers/accessibility/speakup/spk_ttyio.c |  5 ++--
>  drivers/input/serio/serport.c             |  5 ++--
>  drivers/misc/ti-st/st_core.c              |  2 +-
>  drivers/net/can/can327.c                  |  2 +-
>  drivers/net/can/slcan/slcan-core.c        |  5 ++--
>  drivers/net/hamradio/6pack.c              |  4 ++--
>  drivers/net/hamradio/mkiss.c              |  2 +-
>  drivers/net/mctp/mctp-serial.c            |  3 +--
>  drivers/net/ppp/ppp_async.c               |  8 +++----
>  drivers/net/ppp/ppp_synctty.c             | 11 ++++-----
>  drivers/net/slip/slip.c                   |  2 +-
>  drivers/tty/n_gsm.c                       |  2 +-
>  drivers/tty/n_hdlc.c                      |  2 +-
>  drivers/tty/n_tty.c                       | 28 +++++++++++------------
>  drivers/tty/tty.h                         |  2 +-
>  drivers/tty/tty_buffer.c                  | 21 ++++++++---------
>  include/linux/tty_buffer.h                |  4 ++--
>  include/linux/tty_flip.h                  | 22 ++++++++----------
>  include/linux/tty_ldisc.h                 | 18 +++++++--------
>  sound/soc/codecs/cx20442.c                |  4 ++--
>  sound/soc/ti/ams-delta.c                  |  2 +-
>  21 files changed, 73 insertions(+), 81 deletions(-)

> diff --git a/include/linux/tty_buffer.h b/include/linux/tty_buffer.h
> index 6ceb2789e6c8..6f2966b15093 100644
> --- a/include/linux/tty_buffer.h
> +++ b/include/linux/tty_buffer.h
> @@ -22,9 +22,9 @@ struct tty_buffer {
>  	unsigned long data[];
>  };
>  
> -static inline unsigned char *char_buf_ptr(struct tty_buffer *b, int ofs)
> +static inline u8 *char_buf_ptr(struct tty_buffer *b, int ofs)
>  {
> -	return ((unsigned char *)b->data) + ofs;
> +	return ((u8 *)b->data) + ofs;
>  }

Any particular reason why b->data is left unsigned long?

-- 
 i.