linux-kernel - Re: [PATCH blktests v3 00/13] Switch to allowed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0bdc92a4-5eee-075b-2357-27cac97aa524@suse.de>
Date:   Fri, 11 Aug 2023 12:29:17 +0200
From:   Hannes Reinecke <hare@...e.de>
To:     Daniel Wagner <dwagner@...e.de>, linux-nvme@...ts.infradead.org
Cc:     linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
        Chaitanya Kulkarni <kch@...dia.com>,
        Shin'ichiro Kawasaki <shinichiro.kawasaki@....com>,
        Max Gurtovoy <mgurtovoy@...dia.com>,
        Sagi Grimberg <sagi@...mberg.me>,
        James Smart <jsmart2021@...il.com>,
        Bart Van Assche <bvanassche@....org>
Subject: Re: [PATCH blktests v3 00/13] Switch to allowed_host

On 8/11/23 11:36, Daniel Wagner wrote:
> Addressed the comments from v2. I also added cleanup code to _nvmet_cleanup() to
> make sure we do not leak resources when something goes wrong. I run into this
> while testing and all tests after the first failure failed then.
> 
> changes:
> v3:
>   - added new patch: "nvme/043: Use hostnqn to generate DHCAP key"
>   - removed unused variable in "nvme/rc: Add helper for adding/removing to allow list"
>   - added cleanup code to _nvmet_cleanup().
> 
> v2:
>   - updated commit messages
>   - moved the removal of subsys_name to the right patch
>   - added _nvmet_target_{setup|cleanup} helpers
>     this addresses also the 'appears unused' warning by ShellCheck
>   - https://lore.kernel.org/linux-nvme/20230810111317.25273-1-dwagner@suse.de/
> 
> v1:
>   - initial version
>     https://lore.kernel.org/linux-nvme/20230726124644.12619-1-dwagner@suse.de/
> Looks good.
You can add:

Reviewed-by: Hannes Reinecke <hare@...e.de>

Cheers,

Hannes
-- 
Dr. Hannes Reinecke		           Kernel Storage Architect
hare@...e.de			                  +49 911 74053 688
SUSE Software Solutions Germany GmbH, Frankenstr. 146, 90461 Nürnberg
Managing Directors: I. Totev, A. Myers, A. McDonald, M. B. Moerman
(HRB 36809, AG Nürnberg)